In order to make sure the accuracy of coal quality analysis, the collection and making sample are the key, the problem of sample collection of coal pile, top car, coal flow and preparation was analyzed, the corresponding measures were put forward. The result showed that the improvement of sample collection, preparation management, uniform operation and reducing human error could improve the accuracy of the coal quality and reflect the coal grade truly.